Fix for lost HttpHeader items #161
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In cases where there are multiple header entries with the same name, only the first one in the collection was being copied from the OkHttp Header to the HttpResponseMessage.Headers collection
| @@ -152,8 +152,10 @@ string getHeaderSeparator(string name) | |||
|
|
|||
| var respHeaders = resp.Headers(); | |||
| foreach (var k in respHeaders.Names()) { | |||
| ret.Headers.TryAddWithoutValidation(k, respHeaders.Get(k)); | |||
| ret.Content.Headers.TryAddWithoutValidation(k, respHeaders.Get(k)); | |||
| foreach (string item in respHeaders.Values(k)) { | |||
fabionuno
added a commit
to fabionuno/ModernHttpClient
that referenced
this pull request
Nov 20, 2015
Fix for lost HttpHeader items
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In cases where there are multiple header entries with the same name,
only the first one in the collection was being copied from the OkHttp
Header to the HttpResponseMessage.Headers collection